Update snap_notify to allow JSX content
#2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
==========================================
+ Coverage 94.37% 94.38% +0.01%
==========================================
Files 477 477
Lines 10183 10204 +21
Branches 1555 1557 +2
==========================================
+ Hits 9610 9631 +21
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
requested changes
Sep 11, 2024
Mrtenz
reviewed
Sep 24, 2024
Mrtenz
reviewed
Sep 24, 2024
Mrtenz
previously approved these changes
Sep 24, 2024
Mrtenz
previously approved these changes
Sep 24, 2024
Mrtenz
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
title,detailedViewandfooterLinkproperties toinAppnotifications. This allows snaps to provide expanded views with their notifications. ThedetailedViewproperty lets snaps return JSX content with a limited subset of components. ThefooterLinkproperty is optional when providing an expanded view. This content is initially being exposed to populate a modal, but in the future may populate an entire page.